Add network_policy to google_container_cluster #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-lane
force-pushed
the
aaron-lane-fix-ci
branch
2 times, most recently
from
117d58b to
39b40fc
Compare
This fixes the issue with the network_policy_config starting as disabled. hashicorp/terraform-provider-google#3673
aaron-lane
force-pushed
the
aaron-lane-fix-ci
branch
from
39b40fc to
063e70b
Compare
aaron-lane
requested review from
adrienthebo,
Jberlinsky and
morgante
as code owners
morgante
suggested changes
Jun 5, 2019
aaron-lane
added a commit
that referenced
this pull request
Jun 5, 2019
aaron-lane
changed the title
morgante
approved these changes
Jun 5, 2019
aaron-lane
added a commit
that referenced
this pull request
Jun 5, 2019
…changelog [skip ci] Add CHANGELOG entry for #159.
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…-modules/aaron-lane-fix-ci Add network_policy to google_container_cluster
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…-modules/aaron-lane-159-changelog [skip ci] Add CHANGELOG entry for terraform-google-modules#159.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds an explicit
network_policyblock to thegoogle_container_cluster, as recommended by hashicorp/terraform-provider-google#3673. This solves the issue of the partially converged suites which obviates the need for a second converge.